Fix GitHub Enterprise host handling#612
Closed
blokboy wants to merge 4 commits into
Closed
Conversation
|
Taren Marsaw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
CLA was signed but for some reason status doesn't update, possibly due to tracking config of the computer I'm using (and unable to adjust atm). |
robert-inkeep
self-requested a review
July 13, 2026 17:50
|
This PR was closed without merging. |
Contributor
Hi @blokboy, could you add the email address used for this commit to your account? |
Author
|
Should be amended now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Addressing Issue #597
How this was verified
bun run checkfollowed by spinning up the Electron shell locally.Checklist
bun run check(lint, typecheck, tests) locally(Note: The full gate is blocked by an upstream desktop test issue on
origin/main:packages/desktop/tests/unit/verify-native-config-driver.test.mjsimports missingscripts/verify-native-config-in-packaged-dmg.mjs. I also hit sandbox/Cargo env issues first, then worked around those with--env-mode=loose)bun run changeset) if this changes behaviorAfter you open this PR
See CONTRIBUTING.md for details.